Skip to content

Change runtime renderer to use a single StringSink for writing #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 14, 2021
Merged

Change runtime renderer to use a single StringSink for writing #2679

merged 5 commits into from
Jun 14, 2021

Conversation

srawlins
Copy link
Member

No description provided.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Jun 12, 2021
@coveralls
Copy link

coveralls commented Jun 14, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 57.626% when pulling 789b3e3 on srawlins:one-sink into bc0d3e2 on dart-lang:master.

@srawlins srawlins requested a review from jcollins-g June 14, 2021 15:34
@srawlins
Copy link
Member Author

This failing test looks very unrelated.

@jcollins-g
Copy link
Contributor

yep failing test looks like more offset retrieval on synthetic accessors. I thought I had fixed that, will look into it today.

jcollins-g
jcollins-g approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@srawlins srawlins merged commit e5e596c into dart-lang:master Jun 14, 2021
@srawlins srawlins deleted the one-sink branch June 14, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srawlins @coveralls @jcollins-g