Skip to content

Escape variable renders in runtime renderer #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2021
Merged

Escape variable renders in runtime renderer #2676

merged 1 commit into from
Jun 11, 2021

Conversation

srawlins
Copy link
Member

A bit shocking that this bug slipped through, but this corrects escaping behavior for the runtime renderers.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Jun 10, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 57.569% when pulling b2b8e4b on srawlins:escape-in-runtime into 12adc15 on dart-lang:master.

@srawlins srawlins mentioned this pull request Jun 10, 2021
Merged
@srawlins srawlins requested a review from jcollins-g June 10, 2021 23:06
jcollins-g
jcollins-g approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes some sense -- the default templates don't usually depend on us escaping. It is more likely we depend on it not escaping, which this bug wouldn't impact.

@srawlins srawlins merged commit 2d902c0 into dart-lang:master Jun 11, 2021
@srawlins srawlins deleted the escape-in-runtime branch June 11, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jcollins-g jcollins-g jcollins-g approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srawlins @coveralls @jcollins-g