Fix runtime renderers rendering of certain sections #2674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
approved these changes
Jun 11, 2021
| @@ -145,7 +145,7 @@ abstract class RendererBase<T> { | |||
| Template _template; | |||
|
|
|||
| /// The output buffer into which [context] is rendered, using a template. | |||
| final buffer = StringBuffer(); | |||
| StringBuffer buffer = StringBuffer(); | |||
There was a problem hiding this comment.
Why can we not pass buffers into the RendererBase and share them, rather than requiring them to be different for each object? Or, further, maybe this could be part of the idea @kevmoo suggested of just having a stream that we add to.
I'm OK with a big honking TODO/issue filed on cleaning this up, but I think the need for a withBuffer really points to a refactoring using streams being the way to handle this.
There was a problem hiding this comment.
I don't think there is any need for an asynchronous stream API. I've added a TODO to pass around a single StringBuffer.
There was a problem hiding this comment.
Oh, I was thinking StreamSink accessed synchronously. Async definitely seems like overkill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a section is found which is keyed on a context variable other than the top of the stack, then the wrong buffer will be written to.
Before this fix, the test added in this PR renders "Text TwoOne ". Yikes!
It looks like
section()is the only node to refer toparentin this way. (getProperties()does not touch its ownbuffer; it only returns a result directly.)