Frame for merging scoped lookups #2661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
approved these changes
May 27, 2021
lib/src/model/comment_referable.dart
Outdated
| recurseChildrenAndFilter( | ||
| referenceLookup, referenceChildren[referenceLookup.lookup], filter); | ||
|
|
||
| /// Assuming we found a [result], recurse through children, skipping over |
There was a problem hiding this comment.
This comment seems to presuppose some other action. Would it make more sense for this to be private, and refer to [lookupViaScope]?
There was a problem hiding this comment.
Since implementations from other files will probably need to call it (since any of this working will depend on at least Library overriding lookupViaScope to deal with PrefixElements), making it private will not work. Made that more explicit in the comment.
lib/src/model/comment_referable.dart
Outdated
| bool Function(CommentReferable) filter) { | ||
| assert(result != null); | ||
| if (referenceLookup.remaining.isNotEmpty) { | ||
| result = result?.referenceBy(referenceLookup.remaining, |
There was a problem hiding this comment.
The ?. is not necessary with the above assert, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the maximum use of the analyzer's code for looking up symbols will require using the analyzer's
Scopeandlookupcode. Since we don't preserve the AST, construct them ourselves on demand and prioritize the analyzer's lookup, when available, with dartdoc's customizations isolated and added on.