Skip to content

Remove unnecessary imports #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Remove unnecessary imports #2626

merged 2 commits into from
Apr 28, 2021

Conversation

srawlins
Copy link
Member

Every file edited below is one of two cases:

  1. package:dartdoc/dartdoc.dart provided used elements via exports, and the directive importing this library was removed, and one or more finer-grained imports were added.
  2. package:dartdoc/dartdoc.dart provided used elements via exports and declared one or more used elements, so the directive needed to stay. In this case, other imports which are then unnecessary when combined with an import for package:dartdoc/dartdoc.dart, and could be deleted.

The analyzer will start reporting on these unnecessary import directives.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Apr 27, 2021
@coveralls
Copy link

coveralls commented Apr 27, 2021

Coverage Status

Coverage increased (+0.08%) to 57.548% when pulling 5a69ad5 on srawlins:unnecessary into f9a875d on dart-lang:master.

@srawlins srawlins requested a review from jcollins-g April 28, 2021 00:06
@@ -7,9 +7,12 @@ library dartdoc.model_test;
import 'dart:io';

import 'package:async/async.dart';
import 'package:dartdoc/dartdoc.dart';
import 'package:dartdoc/src/element_type.dart';
//import 'package:dartdoc/dartdoc.dart';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why leave this comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes! Done

@srawlins srawlins merged commit 66f4ec1 into dart-lang:master Apr 28, 2021
@srawlins srawlins deleted the unnecessary branch April 28, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants