Skip to content

Use meta at HEAD when using analyzer at HEAD #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Use meta at HEAD when using analyzer at HEAD #2323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
909c928
Use meta at HEAD when using analyzer at HEAD
srawlins Aug 31, 2020
52658cc
Skip sdk-analyzer on stable
srawlins Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ matrix:
allow_failures:
# See https://github.com/dart-lang/dartdoc/issues/2302.
- env: DARTDOC_BOT=flutter
# Some packages at HEAD require 2.10.0-dev.
- env: DARTDOC_BOT=sdk-analyzer
dart: stable

env:
jobs:
Expand Down
10 changes: 7 additions & 3 deletions tool/grind.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,9 +431,11 @@ Future<String> createComparisonDartdoc() async {
return dartdocClean.path;
}

/// Helper function to create a clean version of dartdoc (based on the current
/// directory, assumed to be a git repository), configured to use the head
/// version of the Dart SDK for analyzer, front-end, and kernel.
/// Creates a clean version of dartdoc (based on the current directory, assumed
/// to be a git repository), configured to use packages from the Dart SDK.
///
/// This copy of dartdoc depends on the HEAD versions of various packages
/// developed within the SDK, such as 'analyzer' and 'meta'.
Future<String> createSdkDartdoc() async {
var launcher = SubprocessLauncher('create-sdk-dartdoc');
var dartdocSdk = Directory.systemTemp.createTempSync('dartdoc-sdk');
Expand Down Expand Up @@ -471,6 +473,8 @@ dependency_overrides:
path: '${sdkClone.path}/pkg/analyzer'
_fe_analyzer_shared:
path: '${sdkClone.path}/pkg/_fe_analyzer_shared'
meta:
path: '${sdkClone.path}/pkg/meta'
''', mode: FileMode.append);
await launcher.runStreamed(sdkBin('pub'), ['get'],
workingDirectory: dartdocSdk.path);
Expand Down