Refine detection for NNBD cases and tag generated pages with "Null safety" #2221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is fine. In g3, we will opt to mark |
scheglov
approved these changes
May 28, 2020
Member
|
Do we want to go w/ |
Member
|
Yes, please never use the term 'NNDB' externally. The external name is 'null safety'. We recently added tags on pub.dev, I suggest we align with that, so the tag should say 'Null safety' and the tool-tip should say 'Supports the null safety language feature.'. |
Contributor
Author
jcollins-g
changed the title
Member
|
Awesome, thanks |
szakarias
added a commit
that referenced
this pull request
Sep 5, 2025
`LanguageFeature` was introduced in #2221 for chips indicating null safety. Since we now use chips for other purposes, such as class modifiers, the name is no longer descriptive. This change renames it to `Tag` to better model the general concept of a highlightable tag on an element. This is somewhat related to`Attribute` , and the two could potentially be merged in a future step. Furthermore, `FeatureSet` is removed and its functionality is inlined into `ModelElement`. Finally `ContainerModifier` is extended to store the class modifier description and URL directly, instead of in separate top level maps .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2210.
This puts in the basic scaffolding for tagging pages that are documenting NNBD interfaces and (mostly) boilerplate for connecting to analyzer's package list parsing support.
Tagging @mehmetf and @jdkoren as this touched PackageMeta and markdown templates, respectively.
More extensive tests will wait for a followup -- it's not vital that every case is covered for the preview.