Skip to content

Reenable basic NNBD testing and unblock NNBD support development #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 7, 2020
Merged

Reenable basic NNBD testing and unblock NNBD support development #2200

merged 4 commits into from
May 7, 2020

Conversation

jcollins-g
Copy link
Contributor

Fixes #2148.

The basic support for some parts of NNBD now works again; specifically, understanding late and required.

Also pins our dev version temporarily to work around #2199.

Screen Shot 2020-05-06 at 2 40 15 PM
Screen Shot 2020-05-06 at 2 40 52 PM

@googlebot googlebot added the cla: yes Google CLA check succeeded. label May 6, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.574% when pulling 1e79720 on nnbd into 7c1feb1 on master.

srawlins
srawlins approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh very nice

@jcollins-g jcollins-g merged commit e2fb7e7 into master May 7, 2020
@jcollins-g jcollins-g deleted the nnbd branch August 11, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

@scheglov scheglov Awaiting requested review from scheglov

@stereotype441 stereotype441 Awaiting requested review from stereotype441

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dartdoc can't switch analyzer to non-nullable mode anymore
4 participants
@jcollins-g @coveralls @srawlins @googlebot