Skip to content

Allow null staticElement for const constructors #2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Allow null staticElement for const constructors #2176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e17e724
Allow staticElement to be null
jcollins-g Apr 9, 2020
7d87348
Workaround for missing imports
jcollins-g Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/src/model/getter_setter_combo.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ mixin GetterSetterCombo on ModelElement {
.toString();
Element staticElement =
(constantInitializer as InstanceCreationExpression).staticElement;
assert(staticElement != null,
'${original} should be able to be resolved but an analysis error prevents this');
if (staticElement == null) return original;
Constructor target = ModelElement.fromElement(staticElement, packageGraph);
Class targetClass = target.enclosingElement;
// TODO(jcollins-g): this logic really should be integrated into Constructor,
Expand Down