Skip to content

Work around test failures #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 25, 2020
Merged

Work around test failures #2168

merged 4 commits into from
Mar 25, 2020

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Mar 25, 2020

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Mar 25, 2020
@jcollins-g
Copy link
Contributor Author

This assumes that the analyzer is correct at head inferring Map<int, num Function(List<num>)> as the type of importantComputations, below, instead of Map<int, dynamic Function(List<num)> in analyzer 0.39.4. It seems reasonable to me... @stereotype441

/// Type inference mixing with anonymous functions.
final importantComputations = {
  1: (List<num> a) => a[0] + a[1],
  2: (List<num> a) => a[0] - a[1],
  3: (List<num> a) => a[0] * a[1],
  4: (List<num> a) => -a[0]
};

@jcollins-g jcollins-g changed the title Fix the broken sdk-analyzer test Work around test failures Mar 25, 2020
@coveralls
Copy link

coveralls commented Mar 25, 2020

Coverage Status

Coverage remained the same at 92.018% when pulling 34baeb5 on fix-build into f5aaae5 on master.

Copy link
Member

@stereotype441 stereotype441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jcollins-g jcollins-g merged commit 80dc7ae into master Mar 25, 2020
@jcollins-g jcollins-g deleted the fix-build branch March 25, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants