Skip to content

Generator backend for Markdown #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2020
Merged

Generator backend for Markdown #2151

merged 2 commits into from
Mar 4, 2020

Conversation

jdkoren
Copy link
Contributor

@jdkoren jdkoren commented Feb 26, 2020 •
edited
Loading

This wires up the Markdown backend, but using the existing HTML renderers (Markdown renderers to follow in another change set).

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Feb 26, 2020
@jdkoren jdkoren mentioned this pull request Feb 26, 2020
Merged
@jdkoren
Create Markdown generator backend
d50b10e
@jdkoren
Load markdown templates
9a77044 
Note we need to maintain enumerated lists of partials in order to build
resource URIs.
@jdkoren jdkoren requested a review from jcollins-g February 26, 2020 19:21
jcollins-g
jcollins-g approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. This LGTM.

@jdkoren jdkoren merged commit c535249 into dart-lang:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jcollins-g jcollins-g jcollins-g approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdkoren @jcollins-g @googlebot