Skip to content

Conversation

keertip
Copy link
Collaborator

@keertip keertip commented Sep 18, 2019

Refactor to use summary2 as sometimes FunctionType's are not backed by elements, we have use the type to get the information.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Sep 18, 2019
@coveralls
Copy link

coveralls commented Sep 18, 2019

Coverage Status

Coverage decreased (-0.4%) to 93.512% when pulling 8145c18 on functiontypes into 14a99e5 on master.

Copy link
Contributor

@scheglov scheglov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@keertip
Copy link
Collaborator Author

keertip commented Sep 23, 2019

Fixes #2017

@keertip keertip merged commit 2f3a726 into master Sep 23, 2019
@keertip keertip deleted the functiontypes branch September 23, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants