Skip to content

Update highlightjs pack to include SCSS. #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2019
Merged

Update highlightjs pack to include SCSS. #1907

merged 2 commits into from
Jan 22, 2019

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jan 17, 2019

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jan 17, 2019
@isoos isoos mentioned this pull request Jan 17, 2019
Merged
jcollins-g
jcollins-g approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo
Copy link
Member

kevmoo commented Jan 18, 2019

@isoos – can you land this?

Also, may be worth noting in release notes.

@isoos
Copy link
Collaborator Author

isoos commented Jan 18, 2019

@isoos – can you land this?

I don't have merge rights, feel free to merge any time.

Also, may be worth noting in release notes.

I can add it to the changelog, 0.28 is out, which version would be the next one?

@jcollins-g
Copy link
Contributor

I'll add it to the changelog when I do a new publish.

@jcollins-g jcollins-g merged commit 737755a into dart-lang:master Jan 22, 2019
@jcollins-g jcollins-g mentioned this pull request Jan 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jcollins-g jcollins-g jcollins-g approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isoos @kevmoo @jcollins-g @googlebot