Skip to content

Add tests and patch up remaining dartdoc_options.yaml options #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 11, 2018
Merged

Add tests and patch up remaining dartdoc_options.yaml options #1790

merged 8 commits into from
Oct 11, 2018

Conversation

jcollins-g
Copy link
Contributor

Fixes #1674.

Finally finishes that feature request by cleaning up the remaining options.

  • Makes includeExternal function at all (this was accidentally a noop previously).
  • Adds tests for examplePathPrefix, favicon, footer, footerText, header, and includeExternal.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Oct 10, 2018
@jcollins-g jcollins-g mentioned this pull request Oct 10, 2018
Closed
@jcollins-g jcollins-g requested review from devoncarew and pq October 10, 2018 23:33
pq
pq approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

(Aside: great README docs!)

@jcollins-g
Copy link
Contributor Author

Apparently flutter was using the non-functional version of include-externals so that will have to be removed before this can land.

@jcollins-g jcollins-g mentioned this pull request Oct 11, 2018
Merged
@jcollins-g jcollins-g merged commit b02d1dc into master Oct 11, 2018
@jcollins-g jcollins-g deleted the dartdoc_options branch November 27, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pq pq pq approved these changes

@devoncarew devoncarew Awaiting requested review from devoncarew

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dartdoc needs to support many command line options in the config file
3 participants
@jcollins-g @pq @googlebot