Override modelType to match return type in TypeParameters interface #1755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
approved these changes
Sep 17, 2018
This was referenced Sep 18, 2018
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the
modelTypegetter inherited by most classes is the one inModelElement, which returnsElementType. InTypeParameters, this getter is overridden by an abstract getter which returnsDefinedElementType, a subclass ofElementType.Some subclasses of
ModelElementmix inTypeParameterswithout providing an implementation ofmodelTypereturningDefinedElementType, which means that their implementation ofmodelTypeis not a valid override of the one in its interface.This error is currently caught by neither the CFE nor the analyzer, but it will be reported by the CFE following the fix for dart-lang/sdk#32014.
This PR inserts stubs for checking the type at runtime, similarly to what is already done in the
TopLevelVariableclass.