Skip to content

Conversation

@jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Apr 17, 2018

This is the beginning of the end of separate DartdocConfig and DartdocOption classes.

Adds a method to configure the new DartdocOption arguments similarly to how the dartdoc binary does it, and adds a synthetic DartdocOption class for config options that are computed from other config options.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Apr 17, 2018
@jcollins-g
Copy link
Contributor Author

This is moving toward #1674.

Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcollins-g jcollins-g merged commit de381e6 into master Apr 18, 2018
@jcollins-g jcollins-g deleted the new-dartdoc-option-class+integration branch April 18, 2018 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Google CLA check succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants