Refactor DartDocConfig object usage, part 2 #1662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtdoc tests for travis
pq
approved these changes
Apr 10, 2018
lib/src/package_meta.dart
Outdated
| @@ -49,9 +54,15 @@ abstract class PackageMeta { | |||
| factory PackageMeta.fromDir(Directory dir) { | |||
| Directory original = dir.absolute; | |||
| dir = original; | |||
| if (!original.existsSync()) { | |||
| throw PackageMetaFailure( | |||
There was a problem hiding this comment.
Are you meaning to elide the optional new here? (If so, curious if there's a rationale for when you do and don't.)
There was a problem hiding this comment.
(Actually, maybe you're doing this for exceptions? I notice the same pattern above w/ DartDocFailures.
There was a problem hiding this comment.
The analyzer just doesn't seem to warn about this case regardless of whether previewDart2 is enabled. Fixed.
This was referenced Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues #1661 by moving the generator construction out of bin/dartdoc.dart, and allowing clients to use a factory to instantiate them (progress toward #1609). Next PR in this series will handle moving the sdkDir configuration (#1617).