Rearrange SDK PackageMeta instantiation to be similar to normal packages #1639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e truly need this
pq
approved these changes
Mar 22, 2018
| @@ -104,7 +104,8 @@ void main() { | |||
| }); | |||
|
|
|||
| test('sdk name', () { | |||
| expect(sdkAsPackageGraph.name, equals('Dart SDK')); | |||
| expect(sdkAsPackageGraph.name, equals('Dart')); | |||
There was a problem hiding this comment.
FWIW: equals('Dart') can be simplified to 'Dart'...
devoncarew
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another prep for #1610. This is the first one that has real consequences for how docs will appear. To make dartdoc internally consistent, the SDK is now named "Dart", with a kind: "SDK" rather than "Dart Core" with an empty kind, except for where it was called "Dart SDK" in some places...
Other things Dartdoc documents are of kind "package". With this more consistent handling it opens the doors to making categories work the same for both, which is up next.
With this change, most packages will look the same. Flutter's Dart SDK package on the sidebar will call itself "DART" rather than "DART CORE", and the Dart SDK will show up as "Dart" in some places where it didn't before: