Enable strong mode in Dartdoc #1611
Conversation
|
QQ: I just tried it out on the SDK docs. Noticed that (for example) Before: |
|
...is this the difference between linking to where the "doc comment" is vs where we're getting the implementation? |
| @@ -5091,6 +5030,7 @@ class PackageBuilder { | |||
| PerformanceLog log = new PerformanceLog(null); | |||
| AnalysisDriverScheduler scheduler = new AnalysisDriverScheduler(log); | |||
| AnalysisOptionsImpl options = new AnalysisOptionsImpl(); | |||
| options.strongMode = true; | |||
pubspec.lock
Outdated
| @@ -415,4 +415,4 @@ packages: | |||
| source: hosted | |||
| version: "2.1.13" | |||
| sdks: | |||
| dart: ">=2.0.0-dev <=2.0.0-dev.24.0" | |||
| dart: ">=2.0.0-dev <=2.0.0-edge.0d5cf900b021bf5c9fa593ffa12b15bcd1cc5fe0" | |||
There was a problem hiding this comment.
You'll likely want something like 2.0.0-dev.30.0 instead of a local build number.
Not even sure it's an issue, @devoncarew |
|
@kevmoo Yours is an example where prior to this PR dartdoc was getting it wrong because it prioritized interfaces over classes here: https://github.com/dart-lang/dartdoc/pull/1611/files#diff-4d22582de7e25fdddcfff99652835a1eL791. But because it did so without emitting a warning and noone filed a bug about it, it was off my radar. I can only speculate how this came to be originally as the prioritization of interfaces happened long before I started working on dartdoc. I'd guess it is related to the issue described in #1561 -- unless it prioritized interfaces there were cases where we'd lose information about multiply inherited elements. Regardless, with the analyzer doing the right thing with strong mode enabled we no longer have to decide between a couple slightly wrong ways of resolving this and can simply do it right. The implementation of that operator comes from ListMixin, and so the new docs have correct linkage. |
Fixes #1561, for great justice. The strong mode change shifts a lot of types from dynamic to something inferred. The accompanying refactor also reveals some inherited operators that were disappeared in previous versions (
MultiplyInheritedExecutableElements were silently dropped on the floor, as were operators inherited from private classes).