FutureOr<T> gets interpreted as "dynamic"

[matanlurey]

Example:
https://www.dartdocs.org/documentation/io/0.2.0/io/isExecutable.html

[devoncarew]

Thanks for the report! Note that those docs were generated using dartdoc 0.12.0 - released circa late May.

[matanlurey]

Is it possible for me to opt-in to a newer version of dartdoc? If not it doesn't really help 😖

…

On Tue, Aug 15, 2017, 3:04 PM Devon Carew ***@***.***> wrote: Thanks for the report! Note that those docs were generated using dartdoc 0.12.0 - released circa late May. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1482 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKQ7p1ubPkzbM1bmYA24m0OdwV7CDZbks5sYhYGgaJpZM4O4KiY> .

[devoncarew]

Is it possible for me to opt-in to a newer version of dartdoc?

On dartdocs.org? I'm not familiar enough with it to know. My guess would be no.

My note was more for @jcollins-g, so she didn't spend too much time tracking down something that may no longer be an issue in a current version of dartdoc.

I believe @kevmoo has a plan to support dartdocs.org, or something with similar functionality, in the not too distant future.

[kevmoo]

I believe @kevmoo has a plan to support dartdocs.org, or something with similar functionality, in the not too distant future.

Well, hopefully this year...

[matanlurey]

I tried it out @HEAD, and it still prints dynamic:

I'm going to take a shot fixing it if it is trivial 😈

[matanlurey]

Must be some sort of analyzer bug or misconfiguration of the analysis engine/driver/context - the raw DartType and Element are both dynamic, and even return false for DartType.isDartAsyncFutureOr.

... wait, aha!

var options = new AnalysisOptionsImpl()
      ..enableAssertInitializer = true;

... I thought maybe it was a lack of strongMode = true, but doesn't look like that either.

[matanlurey]

Or... maybe it is? I do see this in analyzer:

// In non-strong mode `FutureOr<T>` is treated as `dynamic`
if (!typeSystem.isStrong && type.isDartAsyncFutureOr) {

... so I'll keep digging.

[matanlurey]

Yup, there are two places AnalysisContext is created, and one wasn't strong mode!

This looks much better:

[matanlurey]

Looks like this is getting fixed by #1611!

[jcollins-g]

Reopening for the tests; I have a PR on deck after the strong mode bit lands, for the FutureOr tests from #1507 plus a few new ones.