New resolver to untangle embedder SDK problem #1605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1601. AnalysisDriver seems to haave some different resolver setup requirements that are challenging to replicate without either reimplementing ContextBuilder or porting over dartdoc to use ContextBuilder (thus requiring a second port when the new API is ready).
So, for now, just duct-tape and bailing wire the thing together with a custom resolver that behaves the way the analyzer expects for cases where embedded SDK components might also be part of a package, while continuing to bypass the more complex setup in ContextBuilder.