Add arbitrary pub package serving to grinder and ignore URI_HAS_NOT_BEEN_GENERATED #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
reviewed
Jan 30, 2018
lib/src/io_utils.dart
Outdated
| @@ -91,7 +91,11 @@ class SubprocessLauncher { | |||
| } | |||
|
|
|||
| SubprocessLauncher(this.context, [Map<String, String> environment]) { | |||
| if (environment == null) this._environment = new Map(); | |||
| if (environment == null) { | |||
There was a problem hiding this comment.
Could put this in the ctor as
SubprocessLauncher(this.context, [Map<String, String> environment]) :
this._environment = environment ?? <String, String>{};Then _environment could be final?
devoncarew
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1595.
Dartdoc will now always ignore this error message. To make testing this sort of thing easier, added grinder support for downloading and serving docs for an arbitrary pub package, and documented some of the
new grinder tools in CONTRIBUTING.md. They're just too useful not to use on a regular basis by regular contributors.