Cosmetic cleanups for type parameters #1558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keertip
approved these changes
Dec 6, 2017
jcollins-g
added a commit
that referenced
this pull request
Dec 7, 2017
* Upgrade to 0.15.0 * One more change.. * Fine-tune changelog and assume #1558 will make it * Changelog tweak to move breaking changes to the top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that dartdoc gets these right, listing and linking them consistently in a few more places seems like the right thing to do. Additionally, insure that the correct span class is in place for type parameters even where they're embedded as part of another name.
This reveals a more general problem that we're mixing assembling complex things likes name + generic types + parameters via templates and via method calls, but IMO that's a refactor for a different day.
We can now link the bound classes in navigation when the user is viewing the class page.
Compare page for LinkedListEntry, old:
New:
The overall appearance change is subtle, just making type parameters the same throughout as other parameters to things.
Compare page for DoubleLinkedQueue, old:
New:
And finally, we have type parameters with bindings on library pages. This is more consistent with how top level functions are displayed in library pages (we show their parameters).
Compare dart:collection's page, old:
New: