Support tables in dartdoc #1557
Conversation
…c-types-constructors
…c-types-constructors+markdown
| @@ -145,7 +145,10 @@ final HtmlEscape htmlEscape = const HtmlEscape(HtmlEscapeMode.ELEMENT); | |||
| final List<md.InlineSyntax> _markdown_syntaxes = [ | |||
| new _InlineCodeSyntax(), | |||
| new _AutolinkWithoutScheme() | |||
| ]; | |||
| ]..addAll(md.ExtensionSet.gitHub.inlineSyntaxes); | |||
There was a problem hiding this comment.
See https://github.com/dart-lang/pub-dartlang-dart/blob/master/app/lib/shared/markdown.dart#L11
Not sure exactly what to do here. Ideally we'd all agree on how markdown is rendered.
I've tried to move the markdown package towards GFM standard. But that doesn't include header links.
Just FYI that we've diverged here...
There was a problem hiding this comment.
Yes, I filed a bug related to this yesterday because markdown's README claims it does have header links for its github extension set: https://github.com/dart-lang/markdown/issues/185.
Dartdoc is always going to have at least a bit of customization, but hopefully we can get it to a point where it is purely additive..
|
Very cool!!! @jcollins-g what needed to get this reflected on existing documentation, for example https://www.dartdocs.org/documentation/url_launcher/1.0.3/index.html ? |
|
A release needs to happen (#1559) and someone will have to do whatever dartdocs.org does to generate docs with the new version. |
Fixes #1453. Dartdoc now supports more of GFM, including tables.