ExtensionSet.gitHub doesn't include ID extensions as documented #1387
Labels
Comments
|
My fault in dart-archive/markdown@cfbadae |
|
Ugh, yeah this is annoying. Basically, GFM is a well-specified Markdown, but GitHub itself doesn't follow the spec, as it does add header anchors. Do we have an |
|
Why not both?
Should be easy to clarify in documentation. One aligns w/ the standard. One
aligns w/ what we see on the site?
…On Sun, Dec 17, 2017 at 8:23 AM, Sam Rawlins ***@***.***> wrote:
Ugh, yeah this is annoying. Basically, GFM is a well-specified Markdown,
but GitHub itself doesn't follow the spec, as it *does* add header
anchors. Do we have an ExtensionSet.gitHubTheWebsite and an
ExtensionSet.gitHubFlavored? Honest question. We want GFM proper for the
JSON spec tests, but we also just want to provide the most useful
ExtensionSet out of the box.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1387>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCiuQIG81chqcBgEsc32mvgMTa6PDQks5tBT_7gaJpZM4Q09K7>
.
|
|
Yeah that's what I'm in favor of. Are my names ok or dumb? :)
…On Sun, Dec 17, 2017, 3:03 PM Kevin Moore ***@***.***> wrote:
Why not both?
Should be easy to clarify in documentation. One aligns w/ the standard. One
aligns w/ what we see on the site?
On Sun, Dec 17, 2017 at 8:23 AM, Sam Rawlins ***@***.***>
wrote:
> Ugh, yeah this is annoying. Basically, GFM is a well-specified Markdown,
> but GitHub itself doesn't follow the spec, as it *does* add header
> anchors. Do we have an ExtensionSet.gitHubTheWebsite and an
> ExtensionSet.gitHubFlavored? Honest question. We want GFM proper for the
> JSON spec tests, but we also just want to provide the most useful
> ExtensionSet out of the box.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#1387
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AABCiuQIG81chqcBgEsc32mvgMTa6PDQks5tBT_7gaJpZM4Q09K7
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1387>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGS_618KyIpHncPGijjRyaAXmW1dpvDks5tBZ2rgaJpZM4Q09K7>
.
|
|
Maybe just gitHubWeb? ...and just give LOTs of comments linking to the spec, etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The README says that ExtensionSet.gitHub includes the extensions
const SetextHeaderWithIdSyntax()andconst HeaderWithIdSyntax(), but it doesn't seem to: https://github.com/dart-lang/markdown/blob/master/lib/src/extension_set.dart#L10.The text was updated successfully, but these errors were encountered: