Skip to content

Fix navigation and constructor docs to include class generics #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 4, 2017

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Dec 1, 2017

Fixes #1027. Make generic arguments for constructors show up in navigation and in the constructor documentation itself so it is easier to understand how to call them.

The new version's LinkedListEntry constructor:
screenshot from 2017-12-01 14 58 19

I've also adjusted navigation for other pages too:

screenshot from 2017-12-01 14 57 01

And finally, an example of a named constructor with type arguments:

screenshot from 2017-12-01 14 52 19

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Dec 1, 2017
@jcollins-g jcollins-g merged commit ce4284c into master Dec 4, 2017
@jcollins-g jcollins-g deleted the fix-generic-types-constructors branch December 4, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants