update the css to match dartlang.org #1416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
suggested changes
May 12, 2017
lib/src/html/template_data.dart
Outdated
| List get navLinks; | ||
| Documentable get navLinksLast => navLinks.last; |
There was a problem hiding this comment.
Might we instead make name and kind getters from the templates and let the template classes define how we get them?
There was a problem hiding this comment.
Renamed to parent, and added some more semantic accessors on TemplateData (name and kind).
| <h5><a href="ex/ex-library.html">ex</a></h5> | ||
| <h5><a href="ex/Deprecated-class.html">Deprecated</a></h5> | ||
|
|
||
| <h5>class Deprecated</h5> |
There was a problem hiding this comment.
Was it a conscious choice to drop the link to class even though this is a member page?
There was a problem hiding this comment.
Discussed off-line - this was part of simplifying the LHS navigation.
|
ptal, the new diff is pretty small |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not change page layout of the top-of-page navigation.
@jcollins-g
