-
Notifications
You must be signed in to change notification settings - Fork 127
some cleanup to the stdout messages we print #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
and before the change:
|
This LGTM, but how well does the new change work with --show-progress? Some of the weirdness we do is to try to make things look OK with both. |
Yup, this changes to end messages with newlines instead of start them w/ newlines. One way we lead with dots, one we trail. I see |
Sounds good. |
this PR has made --show-progress pretty ugly, I'm going to revert it. |
I don't believe that |
* Partial revert of #1413 * remove extra line * dartfmt
This normalizes the blank lines and title case of the stdout we print when generating docs. After this change:
@jcollins-g