Fix issue #1401. #1407
Merged
Fix issue #1401. #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
reviewed
May 8, 2017
lib/src/model.dart
Outdated
| @override | ||
| String get documentation { | ||
| // Verify that we will show exactly one of the summaries. | ||
| Set<bool> assertCheck = new Set()..addAll([hasSetter, hasGetterNoSetter]); |
There was a problem hiding this comment.
I'm having trouble parsing this - what are we asserting here?
There was a problem hiding this comment.
Verify that hasSetter and hasGetterNoSetter are mutuablly exclusive.?
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no framework currently for end-to-end testing of our template output outside manual review of the outputted HTML. To make that easier:
Before:
After:
Regression for this issue is prevented by an assert for now.