show the entire text for the first line of dartdoc #1181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
|
Was concerned that showing the first line full text would create noise on the page when there are a lot of methods. Turns out that more than classes with lots of methods, see libraries with many classes. The page does have more content, and navigation takes some more effort, and that's cause the left/right navs are not sticky. Increased visibility of #779 . Lets land this and look to fixing the nav. lgtm! |
|
Thanks the for review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the full text for the first line of dartdoc. This gives doc writers more control over what the summary of an item is, and gives more context for each item on the summary pages.