Skip to content

Doc references with multiple underscores are not recognized as links #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sethladd opened this issue Aug 5, 2015 · 2 comments
Closed

Doc references with multiple underscores are not recognized as links #768

sethladd opened this issue Aug 5, 2015 · 2 comments
Assignees
@sethladd
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Milestone
0.5.0

Comments

@sethladd
Copy link
Contributor

sethladd commented Aug 5, 2015

For example:

/// Testing [SOME_BIG_NAME]
void foo() {}

The SOME_BIG_NAME won't be recognized as a link.

Blocked by dart-lang/tools#1481
@sethladd sethladd added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Aug 5, 2015
@sethladd sethladd mentioned this issue Aug 5, 2015
Closed
@sethladd
Copy link
Contributor Author

sethladd commented Aug 5, 2015

Update: dart-lang/tools#1481 was fixed (yay!) so once it lands in pub, we can fix this fairly easily.

And, the new markdown package was published. We can proceed with a fix.

@sethladd sethladd self-assigned this Aug 7, 2015
@sethladd sethladd added this to the Branch milestone Aug 7, 2015
@sethladd sethladd added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Aug 7, 2015
@sethladd
Copy link
Contributor Author

sethladd commented Aug 7, 2015

Addressed by #784

@sethladd sethladd closed this as completed Aug 7, 2015
@sethladd sethladd modified the milestones: Branch, 0.5.0 Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sethladd sethladd

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@sethladd