Skip to content

Code blocks in Markdown output don't need HTML escapes #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jdkoren opened this issue Jul 7, 2020 · 0 comments · Fixed by #2253
Closed

Code blocks in Markdown output don't need HTML escapes #2252

jdkoren opened this issue Jul 7, 2020 · 0 comments · Fixed by #2253
Assignees
@jdkoren
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@jdkoren
Copy link
Contributor

jdkoren commented Jul 7, 2020

Dartdoc generates fenced blocks for code, which should be rendered as-is. Using HTML escapes within these fenced blocks results in code that can be diffcult to read.

Screenshot from 2020-07-07 10-12-13
@jdkoren jdkoren added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P2 A bug or feature request we're likely to work on labels Jul 7, 2020
@jdkoren jdkoren self-assigned this Jul 7, 2020
jdkoren added a commit to jdkoren/dartdoc that referenced this issue Jul 7, 2020
@jdkoren
Don't HTML escape source code blocks in Markdown
60f5572 
Adds a renderer in between to control whether or not we apply HTML
escapes to source code blocks.

Fixes dart-lang#2252
@jdkoren jdkoren mentioned this issue Jul 7, 2020
Merged
srawlins pushed a commit that referenced this issue Jul 8, 2020
@jdkoren
Don't HTML escape source code blocks in Markdown (#2253)
b0e2786 
* Don't HTML escape source code blocks in Markdown

Adds a renderer in between to control whether or not we apply HTML
escapes to source code blocks.

Fixes #2252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdkoren jdkoren

Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't HTML escape source code blocks in Markdown jdkoren/dartdoc
1 participant
@jdkoren