Skip to content

Line breaks after template are lost #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hixie opened this issue Nov 26, 2018 · 1 comment · Fixed by #2289
Closed

Line breaks after template are lost #1848

Hixie opened this issue Nov 26, 2018 · 1 comment · Fixed by #2289
Assignees
Labels
customer-flutter Issues originating from important to Flutter P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@Hixie
Copy link
Contributor

Hixie commented Nov 26, 2018

The following:

///    using the [AutomaticKeepAliveClientMixin], then implementing the
///    [wantKeepAlive] getter and calling [updateKeepAlive].
/// {@endtemplate}
///
/// See also:
///
///  * [SliverChildBuilderDelegate], which is a delegate that uses a builder
///    callback to construct the children.

...renders like this:

using the AutomaticKeepAliveClientMixin, then implementing the wantKeepAlive getter and calling updateKeepAlive. See also:

  • SliverChildBuilderDelegate, which is a delegate that uses a builder callback to construct the children.
  • SliverChildListDelegate, which is a delegate that has an explicit list of children.

Notice how the "See also" isn't a separate paragraph.

See e.g. https://master-docs-flutter-io.firebaseapp.com/flutter/widgets/SliverChildDelegate-class.html

@Hixie Hixie added the customer-flutter Issues originating from important to Flutter label Nov 26, 2018
@Hixie
Copy link
Contributor Author

Hixie commented Nov 26, 2018

cc @gspencergoog

@jcollins-g jcollins-g added the P2 A bug or feature request we're likely to work on label Nov 26, 2018
@srawlins srawlins added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Aug 8, 2020
@srawlins srawlins self-assigned this Aug 8, 2020
srawlins added a commit that referenced this issue Aug 11, 2020
Preserve newline following `{@endtemplate}`.

Additionally introduce (some of?) the first unit tests. These live
in test/unit/ for now. This includes a new dev dependency on mockito.

Fixes #1848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-flutter Issues originating from important to Flutter P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants