dartdoc no longer analyzes cleanly on dev.17

[jcollins-g]

@scheglov

Looks like the problem is with constructs like this:

dartdoc/lib/src/html/html_generator_instance.dart

Line 95 in c58f4dd

for (var clazz in filterNonDocumented(lib.allClasses)) {

Might be because of the inferred type of the template argument to filterNonDocumented.

$ grind buildbot
Wrong script snapshot version, expected '5d82aa21085dcd6d9c102151972d2852' found '41bd5eab5c21a0d6a57f3da2d31d9545'
grinder running analyze test test-dartdoc buildbot

analyze
analyze: +  /usr/local/google/home/jcollins/dart/all_sdks/2.0.0-dev.17.0/bin/dartanalyzer --fatal-warnings bin lib test tool
analyze: Analyzing bin, lib, test, tool...
analyze:   error • The getter 'allClasses' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:95:49 • undefined_getter
analyze:   error • The getter 'constructors' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:98:59 • undefined_getter
analyze:   error • The getter 'isCanonical' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:99:28 • undefined_getter
analyze:   error • The getter 'constants' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:103:56 • undefined_getter
analyze:   error • The getter 'isCanonical' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:104:25 • undefined_getter
analyze:   error • The getter 'staticProperties' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:108:56 • undefined_getter
analyze:   error • The getter 'isCanonical' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:109:25 • undefined_getter
analyze:   error • The getter 'propertiesForPages' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:113:56 • undefined_getter
analyze:   error • The getter 'isCanonical' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:114:25 • undefined_getter
analyze:   error • The getter 'methodsForPages' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:118:54 • undefined_getter
analyze:   error • The getter 'isCanonical' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:119:23 • undefined_getter
analyze:   error • The getter 'operatorsForPages' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:123:56 • undefined_getter
analyze:   error • The getter 'isCanonical' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:124:25 • undefined_getter
analyze:   error • The getter 'staticMethods' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:128:54 • undefined_getter
analyze:   error • The getter 'isCanonical' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:129:23 • undefined_getter
analyze:   error • The getter 'enums' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:134:48 • undefined_getter
analyze:   error • The getter 'propertiesForPages' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:136:55 • undefined_getter
analyze:   error • The getter 'operatorsForPages' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:139:55 • undefined_getter
analyze:   error • The getter 'methodsForPages' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:142:53 • undefined_getter
analyze:   error • The getter 'constants' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:147:52 • undefined_getter
analyze:   error • The getter 'properties' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:151:52 • undefined_getter
analyze:   error • The getter 'functions' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:155:52 • undefined_getter
analyze:   error • The getter 'typedefs' isn't defined for the class 'Documentable' at lib/src/html/html_generator_instance.dart:159:51 • undefined_getter
analyze:   error • The getter 'fullyQualifiedNameWithoutLibrary' isn't defined for the class 'Documentable' at lib/src/markdown_processor.dart:496:24 • undefined_getter
analyze:   error • The getter 'fullyQualifiedName' isn't defined for the class 'Documentable' at lib/src/markdown_processor.dart:498:24 • undefined_getter
analyze:   error • The getter 'fullyQualifiedName' isn't defined for the class 'Documentable' at lib/src/markdown_processor.dart:499:41 • undefined_getter
analyze:   error • The getter 'fullyQualifiedNameWithoutLibrary' isn't defined for the class 'Documentable' at lib/src/markdown_processor.dart:500:41 • undefined_getter
analyze: 27 errors found.

[jcollins-g]

Indeed, changing these to:

      for (var clazz in filterNonDocumented<Class>(lib.allClasses)) {

and similar makes this not a problem.

[scheglov]

Yes, this is exactly the problem I thought it is.
https://dart-review.googlesource.com/c/sdk/+/34223 should fix it.

[jcollins-g]

ok. coming up with a PR shortly to pin our bots to .16.