Skip to content

macro implementation doesn't guarantee detection of templates before attempting to apply them #1429

@jcollins-g

Description

@jcollins-g

Even the line here: https://github.com/dart-lang/dartdoc/blob/master/lib/dartdoc.dart#L180 only changes the order in which things are loaded. The unfortunately named _rawDocs are cached by ModelElement's documentation so after this initial pass we'll never see the templates again.

This has always been a problem, but the canonicalization overhaul made this worse because before #1368 we usually recreated ModelElements frequently enough to cloak this (which caused its own problems). Fix with multiple passes or changing how templates work to make them no longer inline (but sourced from a separate file).

Lower priority only because macros don't seem to be in heavy use yet.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3A lower priority bug or feature requesttype-enhancementA request for a change that isn't a bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions