StreamGroup close never completes unless removed first

[curt-weber]

StreamGroup close documentation states that it will close when streams in the group close, but this doesn't appear to be the case:

import 'dart:async';
import 'package:async/async.dart';

Future<void> main() async {
  final controller = StreamController.broadcast();
  final group = StreamGroup.broadcast();
  group.add(controller.stream);
  await controller.close();
  print('controller closed');
  await group.close();
  print('never');
}

The above will close properly if the controllers stream is removed before calling close. Am I missing something?

[suojae]

I've looked into this issue. With the current implementation, when using StreamGroup.broadcast(), the group.close() method doesn't complete when streams in the group are closed. While the documentation states that stream will close once all streams in the group close, it actually only completes if streams are explicitly removed.

I've added a test case and implemented a solution that properly detects when broadcast streams close. Please check out my PR that addresses this issue. 🙌