Wrong File.openRead() test rewritten #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkustermann
approved these changes
Dec 17, 2018
| final c = new Completer(); | ||
| StreamSubscription<List<int>> s = null; | ||
| s = await file.openRead().listen((data) async { | ||
| Expect.listEquals([1, 2, 3], data); |
There was a problem hiding this comment.
The callback given to listen((data) {... }) can be called multiple times, each with a subset of the bytes. There is no guarantee that the very first time we get all 3 bytes, consider changing this to expect that data is a prefix of [1, 2, 3]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was rewrittent to test that returned stream can be listened to