Skip to content

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added a few comments.

Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests updated. Please rereview

@sgrekhov sgrekhov requested a review from eernstg February 20, 2023 09:06
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 40ae4df into dart-lang:master Feb 23, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Feb 24, 2023
2023-02-23 [email protected] Fixes dart-lang/co19#1878. Fix type inference in type_inference_A26_t01.dart (dart-lang/co19#1892)
2023-02-23 [email protected] dart-lang/co19#1401. Patterns execution. Assignment and switch statement tests (dart-lang/co19#1857)
2023-02-23 [email protected] dart-lang/co19#1401. Test for relational pattern with nullable type added (dart-lang/co19#1887)
2023-02-23 [email protected] Fixes dart-lang/co19#1890. Fix collection in scope_A02_t04.dart (dart-lang/co19#1891)
2023-02-23 [email protected] Fixes dart-lang/co19#1877. No compile-time error if type-test is failed in a refutable context (dart-lang/co19#1886)

Change-Id: I25d5fc2113bc1284bc5d90bd91874b77f541c472
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285260
Reviewed-by: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov deleted the co19-1401-execution-1 branch March 22, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants