-
Notifications
You must be signed in to change notification settings - Fork 28
#1401. Patterns execution. Assignment and switch statement tests #1857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Added a few comments.
LanguageFeatures/Patterns/execution_pattern_assignment_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Patterns/execution_pattern_assignment_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Patterns/execution_pattern_assignment_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Patterns/execution_switch_statement_A03_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Patterns/execution_switch_statement_A05_t01.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests updated. Please rereview
LanguageFeatures/Patterns/execution_pattern_assignment_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Patterns/execution_pattern_assignment_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Patterns/execution_pattern_assignment_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Patterns/execution_switch_statement_A03_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Patterns/execution_switch_statement_A05_t01.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2023-02-23 [email protected] Fixes dart-lang/co19#1878. Fix type inference in type_inference_A26_t01.dart (dart-lang/co19#1892) 2023-02-23 [email protected] dart-lang/co19#1401. Patterns execution. Assignment and switch statement tests (dart-lang/co19#1857) 2023-02-23 [email protected] dart-lang/co19#1401. Test for relational pattern with nullable type added (dart-lang/co19#1887) 2023-02-23 [email protected] Fixes dart-lang/co19#1890. Fix collection in scope_A02_t04.dart (dart-lang/co19#1891) 2023-02-23 [email protected] Fixes dart-lang/co19#1877. No compile-time error if type-test is failed in a refutable context (dart-lang/co19#1886) Change-Id: I25d5fc2113bc1284bc5d90bd91874b77f541c472 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285260 Reviewed-by: Alexander Thomas <[email protected]>
No description provided.