#1401. [Patterns] Record pattern tests added #1580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Dec 12, 2022
| // SharedOptions=--enable-experiment=patterns,records | ||
|
|
||
| main() { | ||
| var (:_) = (x1: 1); |
There was a problem hiding this comment.
Cool! That's a counter-example to what I just said. ;-) So this test can be written.
eernstg
reviewed
Dec 13, 2022
I don't think so. I removed this test from this PR but preserved it locally. There should be somewhere in the spec appropriate statement ("the initializing expression isn't assignable to this required type, hence the error") and I'll use it there |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Dec 16, 2022
2022-12-14 [email protected] Fixes dart-lang/co19#1589. Fix wrong expectation in relational tests (dart-lang/co19#1594) 2022-12-14 [email protected] Fixes dart-lang/co19#1588. Fix testing of 'logical-and' subpattern (dart-lang/co19#1593) 2022-12-14 [email protected] dart-lang/co19#1587. Fix testing of 'logical-or' subpattern (dart-lang/co19#1592) 2022-12-14 [email protected] dart-lang/co19#1540. Tests error expectations updated (dart-lang/co19#1543) 2022-12-14 [email protected] dart-lang/co19#1596. Remove CyclicInitializationError from co19 tests (dart-lang/co19#1590) 2022-12-13 [email protected] dart-lang/co19#1401. [Patterns] Switch expressions fixed according to the new syntax (dart-lang/co19#1583) 2022-12-13 [email protected] dart-lang/co19#1401. [Patterns] Record pattern tests added (dart-lang/co19#1580) 2022-12-13 [email protected] dart-lang/co19#1581. Remove use of Deprecated.expires (dart-lang/co19#1584) 2022-12-13 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.6.0 to 3.8.0 (dart-lang/co19#1582) Change-Id: I57f679a9cf6dc9063d5fdfcc630831a2a29abba0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275920 Commit-Queue: Erik Ernst <[email protected]> Reviewed-by: Erik Ernst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.