Skip to content

Test external and abstract variables #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eernstg opened this issue Aug 18, 2020 · 2 comments
Closed

Test external and abstract variables #912

eernstg opened this issue Aug 18, 2020 · 2 comments
Assignees
@sgrekhov

Comments

@eernstg
Copy link
Member

eernstg commented Aug 18, 2020

Cf. the implementation plan, the addition of external and abstract variables to Dart may require some updates.

In particular, there should be tests for abstract and external variables (feature specification here), and other tests may need to be adjusted (because it is not a syntax error any more to have external or abstract in a few locations).
@eernstg eernstg mentioned this issue Aug 18, 2020
Closed
6 tasks
@sgrekhov sgrekhov self-assigned this Oct 7, 2020
@sgrekhov
Copy link
Contributor

sgrekhov commented Oct 7, 2020

@eernstg does the change affect co19_2 tests?

@eernstg
Copy link
Member Author

eernstg commented Oct 7, 2020

No, external and abstract variables are enabled when and only when null safety is enabled.

@sgrekhov sgrekhov reopened this Oct 8, 2020
sgrekhov pushed a commit that referenced this issue Oct 12, 2020
#912. Added tests for external variable declaration
e7371b7
sgrekhov pushed a commit that referenced this issue Oct 14, 2020
#912. Test for static analysis if abstract variables added
fc7ace4
sgrekhov pushed a commit that referenced this issue Oct 15, 2020
#912. Test for static analysis of external variables added
47db76b
sgrekhov pushed a commit that referenced this issue Oct 16, 2020
#912. More test for static analysis of external variables added
a93ffd7
sgrekhov pushed a commit that referenced this issue Oct 19, 2020
#912. More external variables syntax tests added
bf5fb79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @eernstg