#912. More test for static analysis of external variables added

Author: sgrekhov

LanguageFeatures/Abstract-external-fields/static_analysis_external_A01_t01.dart

@@ -4,7 +4,14 @@
  * BSD-style license that can be found in the LICENSE file.
  */
 /**
- * @assertion An external variable declaration D is treated as an external getter declaration and possibly an external setter declaration. The setter is included if and only if D is non-final. The return type of the getter and the parameter type of the setter, if present, is the type of D (which may be declared explicitly, obtained by override inference, or defaulted to dynamic). The parameter of the setter, if present, has the modifier covariant if and only if D has the modifier covariant (the grammar only allows this modifier on external instance variables).
+ * @assertion An external variable declaration D is treated as an external
+ * getter declaration and possibly an external setter declaration. The setter is
+ * included if and only if D is non-final. The return type of the getter and the
+ * parameter type of the setter, if present, is the type of D (which may be
+ * declared explicitly, obtained by override inference, or defaulted to dynamic).
+ * The parameter of the setter, if present, has the modifier covariant if and
+ * only if D has the modifier covariant (the grammar only allows this modifier
+ * on external instance variables).
  *
  * @description Checks that declaration
  *   external int i;
@@ -16,7 +23,7 @@
 external int i;
 
 test() {
-  i;
+  int j = i;
   i = 42;
 }
 

LanguageFeatures/Abstract-external-fields/static_analysis_external_A01_t02.dart

@@ -4,7 +4,14 @@
  * BSD-style license that can be found in the LICENSE file.
  */
 /**
- * @assertion An external variable declaration D is treated as an external getter declaration and possibly an external setter declaration. The setter is included if and only if D is non-final. The return type of the getter and the parameter type of the setter, if present, is the type of D (which may be declared explicitly, obtained by override inference, or defaulted to dynamic). The parameter of the setter, if present, has the modifier covariant if and only if D has the modifier covariant (the grammar only allows this modifier on external instance variables).
+ * @assertion An external variable declaration D is treated as an external
+ * getter declaration and possibly an external setter declaration. The setter is
+ * included if and only if D is non-final. The return type of the getter and the
+ * parameter type of the setter, if present, is the type of D (which may be
+ * declared explicitly, obtained by override inference, or defaulted to dynamic).
+ * The parameter of the setter, if present, has the modifier covariant if and
+ * only if D has the modifier covariant (the grammar only allows this modifier
+ * on external instance variables).
  *
  * @description Checks that declaration
  *   external var i;
@@ -16,7 +23,8 @@
 external var i;
 
 test() {
-  i;
+  int j = i;
+  String s = i;
   i = 42;
   i = "Lily was here";
 }

LanguageFeatures/Abstract-external-fields/static_analysis_external_A01_t03.dart

@@ -4,7 +4,14 @@
  * BSD-style license that can be found in the LICENSE file.
  */
 /**
- * @assertion An external variable declaration D is treated as an external getter declaration and possibly an external setter declaration. The setter is included if and only if D is non-final. The return type of the getter and the parameter type of the setter, if present, is the type of D (which may be declared explicitly, obtained by override inference, or defaulted to dynamic). The parameter of the setter, if present, has the modifier covariant if and only if D has the modifier covariant (the grammar only allows this modifier on external instance variables).
+ * @assertion An external variable declaration D is treated as an external
+ * getter declaration and possibly an external setter declaration. The setter is
+ * included if and only if D is non-final. The return type of the getter and the
+ * parameter type of the setter, if present, is the type of D (which may be
+ * declared explicitly, obtained by override inference, or defaulted to dynamic).
+ * The parameter of the setter, if present, has the modifier covariant if and
+ * only if D has the modifier covariant (the grammar only allows this modifier
+ * on external instance variables).
  *
  * @description Checks that declaration
  *   external int i;
@@ -14,6 +21,7 @@
  * @author [email protected]
  */
 import "../../Utils/expect.dart";
+
 external int i1;
 external var i2;
 

LanguageFeatures/Abstract-external-fields/static_analysis_external_A02_t01.dart

@@ -4,7 +4,14 @@
  * BSD-style license that can be found in the LICENSE file.
  */
 /**
- * @assertion An external variable declaration D is treated as an external getter declaration and possibly an external setter declaration. The setter is included if and only if D is non-final. The return type of the getter and the parameter type of the setter, if present, is the type of D (which may be declared explicitly, obtained by override inference, or defaulted to dynamic). The parameter of the setter, if present, has the modifier covariant if and only if D has the modifier covariant (the grammar only allows this modifier on external instance variables).
+ * @assertion An external variable declaration D is treated as an external
+ * getter declaration and possibly an external setter declaration. The setter is
+ * included if and only if D is non-final. The return type of the getter and the
+ * parameter type of the setter, if present, is the type of D (which may be
+ * declared explicitly, obtained by override inference, or defaulted to dynamic).
+ * The parameter of the setter, if present, has the modifier covariant if and
+ * only if D has the modifier covariant (the grammar only allows this modifier
+ * on external instance variables).
  *
  * @description Checks that declaration
  *   external final int i;

LanguageFeatures/Abstract-external-fields/static_analysis_external_A02_t02.dart

@@ -4,7 +4,14 @@
  * BSD-style license that can be found in the LICENSE file.
  */
 /**
- * @assertion An external variable declaration D is treated as an external getter declaration and possibly an external setter declaration. The setter is included if and only if D is non-final. The return type of the getter and the parameter type of the setter, if present, is the type of D (which may be declared explicitly, obtained by override inference, or defaulted to dynamic). The parameter of the setter, if present, has the modifier covariant if and only if D has the modifier covariant (the grammar only allows this modifier on external instance variables).
+ * @assertion An external variable declaration D is treated as an external
+ * getter declaration and possibly an external setter declaration. The setter is
+ * included if and only if D is non-final. The return type of the getter and the
+ * parameter type of the setter, if present, is the type of D (which may be
+ * declared explicitly, obtained by override inference, or defaulted to dynamic).
+ * The parameter of the setter, if present, has the modifier covariant if and
+ * only if D has the modifier covariant (the grammar only allows this modifier
+ * on external instance variables).
  *
  * @description Checks that declaration
  *   external final int i;

LanguageFeatures/Abstract-external-fields/static_analysis_external_A02_t03.dart

@@ -4,7 +4,14 @@
  * BSD-style license that can be found in the LICENSE file.
  */
 /**
- * @assertion An external variable declaration D is treated as an external getter declaration and possibly an external setter declaration. The setter is included if and only if D is non-final. The return type of the getter and the parameter type of the setter, if present, is the type of D (which may be declared explicitly, obtained by override inference, or defaulted to dynamic). The parameter of the setter, if present, has the modifier covariant if and only if D has the modifier covariant (the grammar only allows this modifier on external instance variables).
+ * @assertion An external variable declaration D is treated as an external
+ * getter declaration and possibly an external setter declaration. The setter is
+ * included if and only if D is non-final. The return type of the getter and the
+ * parameter type of the setter, if present, is the type of D (which may be
+ * declared explicitly, obtained by override inference, or defaulted to dynamic).
+ * The parameter of the setter, if present, has the modifier covariant if and
+ * only if D has the modifier covariant (the grammar only allows this modifier
+ * on external instance variables).
  *
  * @description Checks that declaration
  *   external final i;

LanguageFeatures/Abstract-external-fields/static_analysis_external_A02_t04.dart

@@ -4,7 +4,14 @@
  * BSD-style license that can be found in the LICENSE file.
  */
 /**
- * @assertion An external variable declaration D is treated as an external getter declaration and possibly an external setter declaration. The setter is included if and only if D is non-final. The return type of the getter and the parameter type of the setter, if present, is the type of D (which may be declared explicitly, obtained by override inference, or defaulted to dynamic). The parameter of the setter, if present, has the modifier covariant if and only if D has the modifier covariant (the grammar only allows this modifier on external instance variables).
+ * @assertion An external variable declaration D is treated as an external
+ * getter declaration and possibly an external setter declaration. The setter is
+ * included if and only if D is non-final. The return type of the getter and the
+ * parameter type of the setter, if present, is the type of D (which may be
+ * declared explicitly, obtained by override inference, or defaulted to dynamic).
+ * The parameter of the setter, if present, has the modifier covariant if and
+ * only if D has the modifier covariant (the grammar only allows this modifier
+ * on external instance variables).
  *
  * @description Checks that declaration
  *   external final int i1;

LanguageFeatures/Abstract-external-fields/static_analysis_external_A03_t01.dart

@@ -0,0 +1,36 @@
+/*
+ * Copyright (c) 2020, the Dart project authors.  Please see the AUTHORS file
+ * for details. All rights reserved. Use of this source code is governed by a
+ * BSD-style license that can be found in the LICENSE file.
+ */
+/**
+ * @assertion An external variable declaration D is treated as an external
+ * getter declaration and possibly an external setter declaration. The setter is
+ * included if and only if D is non-final. The return type of the getter and the
+ * parameter type of the setter, if present, is the type of D (which may be
+ * declared explicitly, obtained by override inference, or defaulted to dynamic).
+ * The parameter of the setter, if present, has the modifier covariant if and
+ * only if D has the modifier covariant (the grammar only allows this modifier
+ * on external instance variables).
+ *
+ * @description Checks that declaration
+ *  class A {
+ *    external int i1;
+ * desugared as
+ *  class A {
+ *    external int get i1;
+ *    external void set i1(int _);
+ * @author [email protected]
+ */
+class A {
+  external int i;
+
+  test() {
+    int j = i;
+    i = 42;
+  }
+}
+
+main() {
+  new A();
+}

LanguageFeatures/Abstract-external-fields/static_analysis_external_A03_t02.dart

@@ -0,0 +1,37 @@
+/*
+ * Copyright (c) 2020, the Dart project authors.  Please see the AUTHORS file
+ * for details. All rights reserved. Use of this source code is governed by a
+ * BSD-style license that can be found in the LICENSE file.
+ */
+/**
+ * @assertion An external variable declaration D is treated as an external
+ * getter declaration and possibly an external setter declaration. The setter is
+ * included if and only if D is non-final. The return type of the getter and the
+ * parameter type of the setter, if present, is the type of D (which may be
+ * declared explicitly, obtained by override inference, or defaulted to dynamic).
+ * The parameter of the setter, if present, has the modifier covariant if and
+ * only if D has the modifier covariant (the grammar only allows this modifier
+ * on external instance variables).
+ *
+ * @description Checks that declaration
+ *  class A {
+ *    external var i1;
+ * desugared as
+ *  class A {
+ *    external dynamic get i1;
+ *    external void set i1(dynamic _);
+ * @author [email protected]
+ */
+class A {
+  external var i;
+
+  test() {
+    i;
+    i = 42;
+    i = "Lily was here";
+  }
+}
+
+main() {
+  new A();
+}

LanguageFeatures/Abstract-external-fields/static_analysis_external_A03_t03.dart

@@ -0,0 +1,41 @@
+/*
+ * Copyright (c) 2020, the Dart project authors.  Please see the AUTHORS file
+ * for details. All rights reserved. Use of this source code is governed by a
+ * BSD-style license that can be found in the LICENSE file.
+ */
+/**
+ * @assertion An external variable declaration D is treated as an external
+ * getter declaration and possibly an external setter declaration. The setter is
+ * included if and only if D is non-final. The return type of the getter and the
+ * parameter type of the setter, if present, is the type of D (which may be
+ * declared explicitly, obtained by override inference, or defaulted to dynamic).
+ * The parameter of the setter, if present, has the modifier covariant if and
+ * only if D has the modifier covariant (the grammar only allows this modifier
+ * on external instance variables).
+ *
+ * @description Checks that declaration
+ *  class A {
+ *    external var i1;
+ * desugared as
+ *  class A {
+ *    external dynamic get i1;
+ *    external void set i1(dynamic _);
+ * @author [email protected]
+ */
+import "../../Utils/expect.dart";
+
+class A {
+  external int i1;
+  external var i2;
+
+  test() {
+    Expect.throws(() { i1;}, (e) => e is NoSuchMethodError);
+    Expect.throws(() { i2;}, (e) => e is NoSuchMethodError);
+    Expect.throws(() { i1 = 42;}, (e) => e is NoSuchMethodError);
+    Expect.throws(() { i2 = 42;}, (e) => e is NoSuchMethodError);
+  }
+}
+
+main() {
+  new A().test();
+}

LanguageFeatures/Abstract-external-fields/static_analysis_external_A03_t04.dart

@@ -0,0 +1,39 @@
+/*
+ * Copyright (c) 2020, the Dart project authors.  Please see the AUTHORS file
+ * for details. All rights reserved. Use of this source code is governed by a
+ * BSD-style license that can be found in the LICENSE file.
+ */
+/**
+ * @assertion An external variable declaration D is treated as an external
+ * getter declaration and possibly an external setter declaration. The setter is
+ * included if and only if D is non-final. The return type of the getter and the
+ * parameter type of the setter, if present, is the type of D (which may be
+ * declared explicitly, obtained by override inference, or defaulted to dynamic).
+ * The parameter of the setter, if present, has the modifier covariant if and
+ * only if D has the modifier covariant (the grammar only allows this modifier
+ * on external instance variables).
+ *
+ * @description Checks that declaration
+ *  class A {
+ *    external final int i1;
+ *    external final i2;
+ * desugared as
+ *  class A {
+ *    external int get i1;
+ *    external dynamic get i2;
+ * @author [email protected]
+ */
+class A {
+  external final int i1;
+  external final i2;
+
+  test() {
+    int j = i1;
+    int k = i2;
+    String s = i2;
+  }
+}
+
+main() {
+  new A();
+}

LanguageFeatures/Abstract-external-fields/static_analysis_external_A03_t05.dart

@@ -0,0 +1,45 @@
+/*
+ * Copyright (c) 2020, the Dart project authors.  Please see the AUTHORS file
+ * for details. All rights reserved. Use of this source code is governed by a
+ * BSD-style license that can be found in the LICENSE file.
+ */
+/**
+ * @assertion An external variable declaration D is treated as an external
+ * getter declaration and possibly an external setter declaration. The setter is
+ * included if and only if D is non-final. The return type of the getter and the
+ * parameter type of the setter, if present, is the type of D (which may be
+ * declared explicitly, obtained by override inference, or defaulted to dynamic).
+ * The parameter of the setter, if present, has the modifier covariant if and
+ * only if D has the modifier covariant (the grammar only allows this modifier
+ * on external instance variables).
+ *
+ * @description Checks that declaration
+ *  class A {
+ *    external final int i1;
+ *    external final i2;
+ * desugared as
+ *  class A {
+ *    external int get i1;
+ *    external dynamic get i2;
+ * @author [email protected]
+ */
+class A {
+  external final int i1;
+  external final i2;
+
+  test() {
+    i1 = 42;
+//  ^^
+// [analyzer] unspecified
+// [cfe] unspecified
+
+    i2 = "Lily was here";
+//  ^^
+// [analyzer] unspecified
+// [cfe] unspecified
+  }
+}
+
+main() {
+  new A();
+}

LanguageFeatures/Abstract-external-fields/static_analysis_external_A03_t06.dart

@@ -0,0 +1,40 @@
+/*
+ * Copyright (c) 2020, the Dart project authors.  Please see the AUTHORS file
+ * for details. All rights reserved. Use of this source code is governed by a
+ * BSD-style license that can be found in the LICENSE file.
+ */
+/**
+ * @assertion An external variable declaration D is treated as an external
+ * getter declaration and possibly an external setter declaration. The setter is
+ * included if and only if D is non-final. The return type of the getter and the
+ * parameter type of the setter, if present, is the type of D (which may be
+ * declared explicitly, obtained by override inference, or defaulted to dynamic).
+ * The parameter of the setter, if present, has the modifier covariant if and
+ * only if D has the modifier covariant (the grammar only allows this modifier
+ * on external instance variables).
+ *
+ * @description Checks that declaration
+ *  class A {
+ *    external final int i1;
+ *    external final i2;
+ * desugared as
+ *  class A {
+ *    external int get i1;
+ *    external dynamic get i2;
+ * @author [email protected]
+ */
+import "../../Utils/expect.dart";
+
+class A {
+  external final int i1;
+  external final i2;
+
+  test() {
+    Expect.throws(() { i1;}, (e) => e is NoSuchMethodError);
+    Expect.throws(() { i2;}, (e) => e is NoSuchMethodError);
+  }
+}
+
+main() {
+  new A().test();
+}