Skip to content

Failures on [co19] Roll co19 to 0d38c8081e4da585262ed08ddde3dd85dc779dba #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
athomas opened this issue Feb 7, 2022 · 1 comment
Closed

Failures on [co19] Roll co19 to 0d38c8081e4da585262ed08ddde3dd85dc779dba #1289

athomas opened this issue Feb 7, 2022 · 1 comment
Assignees
@sgrekhov

Comments

@athomas
Copy link
Member

athomas commented Feb 7, 2022

There are new test failures on [co19] Roll co19 to 0d38c8081e4da585262ed08ddde3dd85dc779dba.

The tests

co19/LanguageFeatures/Enhanced-Enum/semantics_A06_t07 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t02 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t03 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t04 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t05 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t06 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t09 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t10 CompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t11 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A10_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A10_t03 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A10_t04 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A10_t05 RuntimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A11_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A11_t02 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/semantics_A14_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t01 CompileTimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t01 RuntimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t02 CompileTimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t02 RuntimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t03 RuntimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t03 CompileTimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t04 CompileTimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t04 RuntimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/WeakReference/expando_key_t04 CompileTimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/WeakReference/expando_key_t05 CompileTimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/WeakReference/weak_reference_target_t01 CompileTimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/WeakReference/weak_reference_target_t02 CompileTimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/WeakReference/weak_reference_target_t03 CompileTimeError (expected Pass)
    and 7 more tests

are failing on configurations

analyzer-asserts-strong-linux
analyzer-asserts-weak-linux
cfe-strong-linux
cfe-weak-linux
dart2js-hostasserts-strong-linux-x64-chrome
dart2js-hostasserts-weak-linux-x64-chrome
dartdevk-strong-linux-release-chrome
dartdevk-weak-linux-release-chrome
dartk-strong-linux-debug-x64
dartk-strong-linux-release-x64
dartk-strong-win-release-x64
dartk-weak-asserts-linux-debug-x64
dartk-weak-asserts-linux-release-x64
dartk-weak-asserts-win-release-x64
dartkp-strong-linux-release-x64
dartkp-weak-asserts-linux-release-x64
@sgrekhov sgrekhov self-assigned this Feb 7, 2022
sgrekhov pushed a commit that referenced this issue Feb 8, 2022
#1289. Roll failures fixed
d7b76bd
@sgrekhov
Copy link
Contributor

sgrekhov commented Feb 8, 2022

Triaged

analyzer...  
new test -> MissingCompileTimeError (expected Pass)  
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t01 Fixed, dart-lang/sdk#48289
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t09 Fixed
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A10_t01 dart-lang/sdk#48290
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A10_t04 dart-lang/sdk#48290
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A11_t02 dart-lang/sdk#48291
analyzer...cfe...  
new test -> MissingCompileTimeError (expected Pass)  
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A06_t07 dart-lang/sdk#48292
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t02 Fixed, dart-lang/sdk#48293
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t03 Fixed, dart-lang/sdk#48293
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t04 Fixed, dart-lang/sdk#48294
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t05 Fixed, dart-lang/sdk#48295
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t06 Fixed, dart-lang/sdk#48295
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t11 Fixed, dart-lang/sdk#48296
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A10_t03 Fixed
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A11_t01 Fixed, dart-lang/sdk#48291
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A14_t01 Fixed, dart-lang/sdk#48293
cfe...dart2js...dartdevk-strong-linux-release-chromedartk...dartkp...  
new test -> CompileTimeError (expected Pass)  
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t10 dart-lang/sdk#48297
dart2js...dartdevk...  
new test -> CompileTimeError (expected Pass)  
✔ co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t01 FFI is not supported on web
✔ co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t02 FFI is not supported on web
✔ co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t03 FFI is not supported on web
✔ co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t04 FFI is not supported on web
✔ co19/LanguageFeatures/FinalizationRegistry/WeakReference/expando_key_t04 FFI is not supported on web
✔ co19/LanguageFeatures/FinalizationRegistry/WeakReference/expando_key_t05 FFI is not supported on web
✔ co19/LanguageFeatures/FinalizationRegistry/WeakReference/weak_reference_target_t01 FFI is not supported on web
✔ co19/LanguageFeatures/FinalizationRegistry/WeakReference/weak_reference_target_t02 FFI is not supported on web
✔ co19/LanguageFeatures/FinalizationRegistry/WeakReference/weak_reference_target_t03 FFI is not supported on web
✔ co19/LanguageFeatures/FinalizationRegistry/WeakReference/weak_reference_target_t04 FFI is not supported on web
✔ co19/LanguageFeatures/FinalizationRegistry/WeakReference/weak_reference_target_t05 FFI is not supported on web
✔ co19/LanguageFeatures/FinalizationRegistry/WeakReference/weak_reference_target_t06 FFI is not supported on web
✔ co19/LanguageFeatures/FinalizationRegistry/WeakReference/weak_reference_target_t07 FFI is not supported on web
✔ co19/LanguageFeatures/FinalizationRegistry/WeakReference/weak_reference_target_t08 FFI is not supported on web
dartdevk...  
new test -> RuntimeError (expected Pass)  
✔ co19/LanguageFeatures/Enhanced-Enum/semantics_A10_t05 dart-lang/sdk#48299
dartk...  
new test -> RuntimeError (expected Pass)  
✔ co19/LanguageFeatures/FinalizationRegistry/WeakReference/weak_reference_target_t06 Fixed
dartk...dartkp...  
new test -> RuntimeError (expected Pass)  
✔ co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t01 UnimplementedError
✔ co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t02 UnimplementedError
✔ co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t03 UnimplementedError
✔ co19/LanguageFeatures/FinalizationRegistry/Finalizer/Finalizer_A01_t04 UnimplementedError
dartk...  
new test -> RuntimeError (expected Pass)  
✔ co19/LanguageFeatures/FinalizationRegistry/WeakReference/weak_reference_target_t05 Fixed

@sgrekhov sgrekhov closed this as completed Feb 8, 2022
sgrekhov pushed a commit that referenced this issue Feb 8, 2022
#1289. More roll failures fixed
7953f3b
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 14, 2022
@athomas
[co19] Roll co19 to 310e789d81336ba2b6141788f200e643aa8f0ef7
480c8a8 
2022-02-11 [email protected] dart-lang/co19#1260. WeakReference.target test added
2022-02-11 [email protected] dart-lang/co19#1260. Test that use ffi moved to a separate directory
2022-02-11 [email protected] dart-lang/co19#1260. Optional parameters added to triggerGcWithDelay()
2022-02-10 [email protected] dart-lang/co19#1260: Added tests for Finalizer.attach method.
2022-02-10 [email protected] dart-lang/co19#1260. Unnecessary delays removed form WeakReference tests
2022-02-10 [email protected] dart-lang/co19#1292. Compile error in Enhanced enums example fixed
2022-02-10 [email protected] Fixes dart-lang/co19#1297. User-written 'index' is not allowed
2022-02-10 [email protected] Fixes dart-lang/co19#1293. Change expected error location in analyzer
2022-02-09 [email protected] dart-lang/co19#1260: Added tests for Finalizer.
2022-02-09 [email protected] dart-lang/co19#1258. Enhanced enums test fixed, issue numbers added
2022-02-09 [email protected] dart-lang/co19#1260: Added tests for Finalizer.
2022-02-08 [email protected] dart-lang/co19#1260: Added tests for Finalizer.
2022-02-08 [email protected] dart-lang/co19#1258. Add more tests on user-written 'index' and 'values'
2022-02-08 [email protected] dart-lang/co19#1289. More roll failures fixed
2022-02-08 [email protected] dart-lang/co19#1289. Roll failures fixed
2022-02-08 [email protected] Fixes dart-lang/co19#1290. Constant constructors can't have a body
2022-02-08 [email protected] dart-lang/co19#1260: Updated LanguageFeatures/FinalizationRegistry/Finalizer tests.
2022-02-07 [email protected] dart-lang/co19#1258. Update Enhanced Enums test. Now user-written 'values' and 'index' are not allowed
2022-02-07 [email protected] Fixes dart-lang/co19#1288. Remove 'index' declaration

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: I67d2028c58733088b5e46ea83092af1fa41c3c53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232600
Reviewed-by: William Hesse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @athomas