Skip to content

co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t04 #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scheglov opened this issue Jan 28, 2022 · 0 comments
Closed

co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t04 #1284

scheglov opened this issue Jan 28, 2022 · 0 comments
Assignees

Comments

@scheglov
Copy link

The specification says that ; is optional: The ; after the identifier list is optional if there is nothing else in the declaration (for backwards compatibility), and required if there is any member declaration after it. The identifier list may have a trailing comma in either case (like now). I think "optional" does not mean "not allowed".

FAILED: dart2analyzer-none release_x64 co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t04
Expected: Pass
Actual: MissingCompileTimeError

--- Command "dart2analyzer" (took 12.000640s):
DART_CONFIGURATION=ReleaseX64 sdk/bin/dartanalyzer -Dtest_runner.configuration=custom-configuration-1 --enable-experiment=enhanced-enums --ignore-unrecognized-flags --packages=/Users/scheglov/Source/Dart/sdk.git/sdk/.packages --format=json --no-hints /Users/scheglov/Source/Dart/sdk.git/sdk/tests/co19/src/LanguageFeatures/Enhanced-Enum/grammar_A01_t04.dart

static error failures:
- Missing expected unspecified error at line 29, column 3, length 1.

- Missing expected unspecified error at line 38, column 3, length 1.

--- Re-run this test:
python3 tools/test.py -m release -c dart2analyzer co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t04
@sgrekhov sgrekhov self-assigned this Jan 31, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 9, 2022
2022-02-07 [email protected] dart-lang/co19#1260: Moved Weak Reference tests to LanguageFeatures/WeakReference directory. Added tests for Finalizer constructor.
2022-02-06 [email protected] Fixes dart-lang/co19#1287. Typos fixed
2022-02-04 [email protected] dart-lang/co19#1260. WeakReference tests added
2022-02-04 [email protected] Fixes dart-lang/co19#1286. Expect an error if mixin application on enum introduces anyv instance variables
2022-02-03 [email protected] dart-lang/co19#1285. One more roll failure fixed
2022-02-03 [email protected] dart-lang/co19#1285. Roll failures fixed, issue numbers added
2022-02-02 [email protected] dart-lang/co19#1260. GC utils library added
2022-02-01 [email protected] dart-lang/co19#1260. WeakReferences tests for Expando key added
2022-01-31 [email protected] dart-lang/co19#1258. More Enhanced Enums semantics tests added
2022-01-31 [email protected] dart-lang/co19#1281. Expected error location updated
2022-01-31 [email protected] Fixes dart-lang/co19#1284. Test changed to allow ; after identifier list
2022-01-31 [email protected] Fixes dart-lang/co19#1283. Typos fixed
2022-01-31 [email protected] Fixes dart-lang/co19#1282. Typo fixed
2022-01-27 [email protected] dart-lang/co19#1258. More Enhanced Enums semantics tests added
2022-01-26 [email protected] dart-lang/co19#1258. More Enhanced Enums semantics tests added
2022-01-25 [email protected] Fixes dart-lang/co19#1258. More Enhanced Enums semantics tests added
2022-01-25 [email protected] dart-lang/co19#1280. Roll failure fixed

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: Iae324aa5e53c3f34b630958410a1f1b4a48f64ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231941
Reviewed-by: William Hesse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants