Skip to content

LanguageFeatures/Enhanced-Enum/grammar_A09_t04 #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexmarkov opened this issue Jan 28, 2022 · 0 comments
Closed

LanguageFeatures/Enhanced-Enum/grammar_A09_t04 #1283

alexmarkov opened this issue Jan 28, 2022 · 0 comments
Assignees
@sgrekhov

Comments

@alexmarkov
Copy link

This test has an incorrect field initializer:

co19/LanguageFeatures/Enhanced-Enum/grammar_A09_t04.dart

Lines 35 to 36 in aa23d14

final T _t;
const E2(T t) : this.t = _t;

It references field in the right-hand side. Probably it should be

 const E2(T t) : this._t = t;

Also, the following code is not correct: value of T is returned as int without a cast:

co19/LanguageFeatures/Enhanced-Enum/grammar_A09_t04.dart

Line 37 in aa23d14

int call(T t) => _t;

@sgrekhov sgrekhov self-assigned this Jan 31, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 9, 2022
@athomas
[co19] Roll co19 to 0d38c8081e4da585262ed08ddde3dd85dc779dba
a4da39f 
2022-02-07 [email protected] dart-lang/co19#1260: Moved Weak Reference tests to LanguageFeatures/WeakReference directory. Added tests for Finalizer constructor.
2022-02-06 [email protected] Fixes dart-lang/co19#1287. Typos fixed
2022-02-04 [email protected] dart-lang/co19#1260. WeakReference tests added
2022-02-04 [email protected] Fixes dart-lang/co19#1286. Expect an error if mixin application on enum introduces anyv instance variables
2022-02-03 [email protected] dart-lang/co19#1285. One more roll failure fixed
2022-02-03 [email protected] dart-lang/co19#1285. Roll failures fixed, issue numbers added
2022-02-02 [email protected] dart-lang/co19#1260. GC utils library added
2022-02-01 [email protected] dart-lang/co19#1260. WeakReferences tests for Expando key added
2022-01-31 [email protected] dart-lang/co19#1258. More Enhanced Enums semantics tests added
2022-01-31 [email protected] dart-lang/co19#1281. Expected error location updated
2022-01-31 [email protected] Fixes dart-lang/co19#1284. Test changed to allow ; after identifier list
2022-01-31 [email protected] Fixes dart-lang/co19#1283. Typos fixed
2022-01-31 [email protected] Fixes dart-lang/co19#1282. Typo fixed
2022-01-27 [email protected] dart-lang/co19#1258. More Enhanced Enums semantics tests added
2022-01-26 [email protected] dart-lang/co19#1258. More Enhanced Enums semantics tests added
2022-01-25 [email protected] Fixes dart-lang/co19#1258. More Enhanced Enums semantics tests added
2022-01-25 [email protected] dart-lang/co19#1280. Roll failure fixed

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: Iae324aa5e53c3f34b630958410a1f1b4a48f64ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231941
Reviewed-by: William Hesse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @alexmarkov