is the test app in test/app working?

[devoncarew]

Are people able to run the app in test/app? It doesn't seem like it should work as is, but I want to make sure that it wasn't changes of mine that regressed it.

[adam-singer]

On f9429fb I was able to run test/app in canary. IIRC @kevmoo was having issues with failing tests on chrome.window which may have been resolved in the dart2js builds I was doing locally. The test folder def needs some love.

I just ran them for the first time in a while... the chrome.app.window tests are failing for me on Windows 7x64:

ERROR
chrome.app.window.Test a vanilla call to create() with no options. Teardown failed: Caught Bad state: Cannot fire new event. Controller is already firing an event
dart:async _BroadcastStreamController.close
package:chrome/src/app.dart 225:20 AppWindow.dispose

It looks like something has changed in dart:async ; needs further investigation I think. If you change the following StreamController in app.dart to be async, then it works:

final _onClosed = new StreamController.broadcast(sync: true);

But, that was sync for a valid reason. In my Chrome Application, I listen to that in order to perform some cleanup work, and I only receive it before the window closes if I use a synchronous stream as the comment says;

// We must send the onClosed event synchronously so that the current
// AppWindow has a chance to perform some work on closing.

I can investigate more, I am not sure why the Controller is in a Bad state ...

Ok, I submitted a workaround / fix to the tests that works for me on Windows 7x64 - I left this issue open in case you are seeing a different error

cheers

[adam-singer]

@rmsmith The workaround for window delays are still not working for me on Dartium and Canary MacOSX. Actually crashes the browser.

@financecoding yikes! I'm sorry to hear that, please feel free to disable / remove them, whatever you need to do.

[adam-singer]

yep, hopefully got it under temporary control 👍

[devoncarew]

Seems like it's working again - will close this issue out.