feat: Create new rule avoid_collection_methods_with_unrelated_types

[fzyzcjy]

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[x] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Close #701

Is there anything you'd like reviewers to focus on?

[fzyzcjy]

Tests have passed locally :)

[incendial]

@fzyzcjy thank you so much for the contribution. This looks 🔥

I guess, the main questions is about supporting not only maps, but sets and lists too. What do you think?

Also, was it hard to add a rule? Maybe you have faced some problems that we should address on order to make the contribution process easier?

[fzyzcjy]

I guess, the main questions is about supporting not only maps, but sets and lists too. What do you think?

Following the original issue, I may also add Iterable.contains.

Also, was it hard to add a rule? Maybe you have faced some problems that we should address on order to make the contribution process easier?

I just copy-and-paste-and-modify from sibling rules ;) It is ok imho

[fzyzcjy]

@incendial Done and ready for review (again)

Maybe have a look at .md to see what is supported now

[incendial]

@fzyzcjy looks amazing, thanks for addressing all the questions!

I just copy-and-paste-and-modify from sibling rules ;) It is ok imho

Thanks for answering, we don't have many people contributing new rules, so I was wondering, if it's something wrong with the flow.

[incendial]

The only thing missing is the entry in changelog under Unreleased section, like feat: add static code diagnostic avoid-collection-methods-with-unrelated-types. Could you add it?

Now we'll run the rule on different public codebases in order to avoid possible edge-cases.

[fzyzcjy]

You are welcome! Done.

[codecov]

Codecov Report

Merging #705 (1a5579f) into master (997dfd3) will increase coverage by 0.11%.
The diff coverage is 95.50%.

@@            Coverage Diff             @@
##           master     #705      +/-   ##
==========================================
+ Coverage   86.63%   86.75%   +0.11%     
==========================================
  Files         261      263       +2     
  Lines        5551     5631      +80     
==========================================
+ Hits         4809     4885      +76     
- Misses        742      746       +4     

Impacted Files	Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart	92.40% <0.00%> (-2.41%)	⬇️
lib/src/utils/dart_types_utils.dart	90.47% <90.00%> (-9.53%)	⬇️
..._collection_methods_with_unrelated_types_rule.dart	100.00% <100.00%> (ø)
...llection_methods_with_unrelated_types/visitor.dart	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997dfd3...1a5579f. Read the comment docs.

[dkrutskikh]

@fzyzcjy thank you for contribute

[fzyzcjy]

You are welcome!