Skip to content
This repository was archived by the owner on Mar 16, 2020. It is now read-only.

Conversation

devoncarew
Copy link
Contributor

fix #36

@sethladd, can you land this and push a new version of the plugin?

@sethladd
Copy link
Contributor

Let's land #42 and then we'll publish.

@devoncarew
Copy link
Contributor Author

Reverted the package.json changes; landing.

devoncarew added a commit that referenced this pull request Jul 10, 2015
@devoncarew devoncarew merged commit a93e346 into master Jul 10, 2015
@sethladd sethladd deleted the devoncarew_rev branch July 10, 2015 23:00
@radicaled
Copy link
Contributor

apm publish handles tagging versions; maybe you should rely on that when you're ready to launch?

apm publish {major|minor|patch}

@devoncarew
Copy link
Contributor Author

Yup, Seth let me know I shouldn't be manually reving the package version. Would like to figure out some system for keeping the pubspec and changelog versions in sync.

@radicaled
Copy link
Contributor

We have grindr, maybe copy the apm flow:

dart tool/grind.dart publish $version
==> dirty check, explode if tree is dirty
==> make sure synced with master, explode if not
==> parse package.json, get $parsedVersion
==> increment $parsedVersion => $newVersion, update pubspec.yaml, update package.json
==> updates CHANGELOG.md, replaces "# Upcoming Version" ==> "# $newVersion"
==> git commit -a -m "foo bar"
==> git tag $newVersion
==> git push -t
==> apm publish -t $version

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

we need to keep our changelog updated
3 participants