This repository was archived by the owner on Oct 16, 2022. It is now read-only.
Send 405 (Method Not Allowed) – for requests that are not HEAD/GET
#55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
reviewed
May 7, 2021
lib/src/static_handler.dart
Outdated
| bool useHeaderBytesForContentType = false, | ||
| MimeTypeResolver? contentTypeResolver}) { | ||
| /// | ||
| /// If [onlyGetMethods] is `true`, then OK (200) responses are only sent for GET |
Contributor
There was a problem hiding this comment.
When would I choose to use this or not use this? Do we expect most users to want this behavior?
Contributor
Author
There was a problem hiding this comment.
I think most users will want it.
But it's a breaking (behavior) change.
Do a breaking change release instead?
Contributor
Author
There was a problem hiding this comment.
Also: should return a 405 - https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/405
Contributor
Author
There was a problem hiding this comment.
Try it as a not-breaking change.
See if things are okay in Google3 @natebosch ?
kevmoo
force-pushed
the
i53_correct_method
branch
from
8a92124 to
a52098b
Compare
kevmoo
changed the title
HEAD/GET
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/shelf#227
Also prepare to release v1.1.0