This repository was archived by the owner on Nov 20, 2024. It is now read-only.
unnecessary_parenthesis: parenthesized pattern precedence (WIP) #4075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
reviewed
Feb 15, 2023
| @override | ||
| void visitParenthesizedPattern(ParenthesizedPattern node) { | ||
| var parent = node.parent; | ||
| if (parent is DartPattern && parent.precedence < node.precedence) { |
There was a problem hiding this comment.
This looks good.
We should explore whether we want to flag any use of a parenthesized pattern where the parent isn't another pattern. Seems like that would be a good case, but I'm not familiar enough with the patterns feature to know for sure.
There was a problem hiding this comment.
Nor am I. I'll do a little digging. Thanks!
|
This needs a more thorough revisit. Closing for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: dart-lang/sdk#59037
/cc @bwilkerson