wip

Author: pq

lib/src/rules/unnecessary_parenthesis.dart

@@ -88,10 +88,10 @@ class _Visitor extends SimpleAstVisitor<void> {
   @override
   void visitParenthesizedPattern(ParenthesizedPattern node) {
     //https://github.com/dart-lang/linter/issues/4062
-    // var parent = node.parent;
-    // if (parent is DartPattern && parent.precedence < node.precedence) {
-    //   rule.reportLint(node);
-    // }
+    var parent = node.parent;
+    if (parent is DartPattern && parent.precedence < node.pattern.precedence) {
+      rule.reportLint(node);
+    }
   }
 
   @override

test/rules/unnecessary_parenthesis_test.dart

@@ -36,26 +36,27 @@ void f(int i) {
   }
 
   ///https://github.com/dart-lang/linter/issues/4062
-  @FailingTest(issue: 'https://github.com/dart-lang/sdk/issues/51426')
+  //@FailingTest(issue: 'https://github.com/dart-lang/sdk/issues/51426')
+  @soloTest
   test_parenthesized_listPattern() async {
     await assertDiagnostics(r'''
-void f(Object x) {
-  if (x case [(<3), 12]) return;
+void f(List<int> l) {
+  if (l case [(<3), 12]) return;
 }
 ''', [
       lint(41, 11),
     ]);
   }
 
-  ///https://github.com/dart-lang/linter/issues/4062
-  @FailingTest(issue: 'https://github.com/dart-lang/sdk/issues/51426')
+  @soloTest
   test_parenthesized_relationalPattern() async {
     await assertDiagnostics(r'''
-void f(int x) {
-  if (x case (<3) || (>5)) return;
+void f(List<int> l) {
+  if (l case [(<3) || (>5)]) return;
 }
 ''', [
-      lint(41, 11),
+      lint(36, 4),
+      lint(44, 4),
     ]);
   }
 }